Skip to content

Add addStreams to RTCRtpSender #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2023
Merged

Add addStreams to RTCRtpSender #23

merged 1 commit into from
Mar 27, 2023

Conversation

amantoux
Copy link
Contributor

@amantoux amantoux commented Mar 27, 2023 •
edited
Loading

In order to have transceiver-only usage in RTC sessions, RTCRtpSender must be able to have streams set as per https://blog.mozilla.org/webrtc/rtcrtptransceiver-explored/

This PR enriches the Flutter API RTCRtpSender with the method addStreams

Depends on flutter-webrtc/webrtc-interface#15 -> needs to be reviewed first

@amantoux amantoux mentioned this pull request Mar 27, 2023
Merged
6 tasks
@amantoux amantoux marked this pull request as ready for review March 27, 2023 15:22
cloudwebrtc
cloudwebrtc approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cloudwebrtc cloudwebrtc merged commit ba69e42 into flutter-webrtc:main Mar 27, 2023
@amantoux amantoux deleted the rtc_sender_add_streams branch July 4, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amantoux @cloudwebrtc